Performance improvements for Blob #416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what's up with Travis, it's pulling an old commit that I squashed. |
|
Looks like a worthwhile change, but breaking API compatibility ( |
|
Replaced w/ #1167 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Blobs a lot in our database and find the current API to not allow much performance tuning. This pull request address this by:
There should be no impact on existing code. The swift-corelibs project contains a working NSData implementation for Linux so I can't see why we shouldn't use NSData.
The only pitfall I can see is if a user grabs a Blob from a NSMutableData object, I could potentially put some checks in place for this?